Open
Conversation
…ne. Now a communication between Knowledge and RS needs to be implemented via PrologCPPQueries and some additional rules to check if a annotator can be reconfigured to meet the requested requirements. In order to achieve this final communication, an additonal reconfiguration service needs to be implemented.
…ix name resolving.
Collaborator
|
@Sanic you'll look through this ? if you need help let me know. It's been a while since I looked at the code. I would def not recommend merging without having the code coverage increase. Some of these changes affect basic pipeline planning capabilities and we should make sure that they still work |
Contributor
|
Hi @bbferka But you also raise a good point to test also the basic planning capabilities. @evankapi Could you please keep that in mind? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extension includes reconfigurable annotators and updates to the query system to handle different inputs / outputs of annotator setups. Those setups are also considered during the pipeline planning via the query service.